linux-kernel - Re: [PATCH] drivercore: deferral race condition fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140402231857.GB26696@kroah.com>
Date:	Wed, 2 Apr 2014 16:18:57 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Mark Brown <broonie@...nel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] drivercore: deferral race condition fix

On Wed, Apr 02, 2014 at 09:38:06AM +0300, Peter Ujfalusi wrote:
> Hi Greg,
> 
> On 03/04/2014 06:56 AM, Mark Brown wrote:
> > On Mon, Mar 03, 2014 at 10:26:59AM +0200, Peter Ujfalusi wrote:
> > 
> >> I think it is correct to detect this situation without the need to have non
> >> related drivers to be probed.
> >> The patch is doing this exactly: detects if we had successful parallel driver
> >> probe(s) while another driver was probing which ends up requesting to be
> >> deferred. We only try the deferred list again if this condition has been
> >> detected, we do not loop on the deferred list, we do not try the list again if
> >> there were no other drivers loaded since nothing happened which could satisfy
> >> the driver asking to be deferred.
> > 
> > It's certainly the simplest approach I can think of - anything else
> > would seem to involve looking to see if we're running deferred probes
> > and trying to add things to the list while that's going on which seems
> > like it might be hairy.
> 
> Do you want me to resend this patch in hope that it is going to be taken or do
> you have other method in mind to deal with the situation I have described and
> fixed with this patch?

Can you resend, I've totally lost the idea of the original patch.  And
if others agree with it, getting acks from them (like Grant) would be
great.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/