linux-kernel - Re: [PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Apr 2014 10:41:01 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sherif Shehab Aldin <shehabaldin.sherif@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, silentquote@...il.com
Subject: Re: [PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary
 typedefs from hfa384x_usb.c

On Thu, Apr 03, 2014 at 02:25:54AM +0200, Sherif Shehab Aldin wrote:
> Removed unnecessary typedefs from hfa384x_usb.c
> 
> Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@...il.com>

You've broken this patch set up in a wrong way.  It should have just
been one patch.  Don't introduce a warning and fix it later.  The two
changes are closely related so they fall under the one thing per patch
rule.

The subject for this patch is nonsense because it fixes a long line.  I
can see how you meant is as in you were fixing up the typedef patch that
context will be lost in the final git log.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/