linux-kernel - Re: [PATCH] v3.14-7247-gcd6362b drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140403102931.GK6991@mwanda>
Date:	Thu, 3 Apr 2014 13:29:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mike Sampson <mike@...bodata.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Andreas Dilger <andreas.dilger@...el.com>,
	Kees Cook <keescook@...omium.org>,
	Peng Tao <bergwolf@...il.com>, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH] v3.14-7247-gcd6362b
 drivers/staging/lustre/lustre/libcfs/workitem.c Fix sparse warning.

On Thu, Apr 03, 2014 at 08:43:28PM +1100, Mike Sampson wrote:
> Signed-off-by: Mike Sampson <mike@...bodata.com>
> 
> This fixes a sparse warning:
> warning: symbol 'cfs_wi_data' was not declared. Should it be static?
> 

Patch is ok.  Signed off should go at the end instead of at the start of
the commit message.  The subject should be:

[PATCH] Staging: lustre: mark a variable static in workitem.c

Espcially notice how I removed the "v3.14-7247-gcd6362b" and chose a
better prefix.  Btw, for these kinds of changes, then you should be
working against -next.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/