linux-kernel - Re: [PATCH v2 1/2] usb: doc: udc-xilinx: Add devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140403145934.GE14162@saruman.home>
Date:	Thu, 3 Apr 2014 09:59:34 -0500
From:	Felipe Balbi <balbi@...com>
To:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>
CC:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<michals@...inx.com>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
Subject: Re: [PATCH v2 1/2] usb: doc: udc-xilinx: Add devicetree bindings

On Thu, Apr 03, 2014 at 01:05:18PM +0530, Subbaraya Sundeep Bhatta wrote:
> Add devicetree bindings for Xilinx axi udc driver.
> 
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
> ---
> Changes for v2:
> 	- replaced xlnx,include-dma with xlnx,has-builtin-dma
> 
>  .../devicetree/bindings/usb/udc-xilinx.txt         |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/usb/udc-xilinx.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> new file mode 100644
> index 0000000..7c24fac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> @@ -0,0 +1,20 @@
> +Xilinx AXI USB2 device controller
> +
> +Required properties:
> +- compatible		: Should be "xlnx,axi-usb2-device-4.00.a"
> +- reg			: Physical base address and size of the Axi USB2
> +			  device registers map.
> +- interrupts		: Property with a value describing the interrupt
> +			  number.
> +- interrupt-parent	: Must be core interrupt controller
> +- xlnx,has-builtin-dma	: if DMA is included

isn't there a configuration register to tell you this ?

> +
> +Example:
> + 		axi-usb2-device@...00000 {
> +                        compatible = "xlnx,axi-usb2-device-4.00.a";
> +                        interrupt-parent = <0x1>;

why isn't interrupt-parent a phandle ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)