[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <00f301cf4ee2$1f2445c0$5d6cd140$@samsung.com>
Date: Thu, 03 Apr 2014 11:12:08 +0900
From: Kukjin Kim <kgene.kim@...sung.com>
To: 'Pankaj Dubey' <pankaj.dubey@...sung.com>, monstr@...str.eu
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-samsung-soc@...r.kernel.org, linux@....linux.org.uk,
chow.kim@...sung.com
Subject: RE: [PATCH 02/10] ARM: EXYNOS: Correct file path in comment message
Pankaj Dubey wrote:
>
> Hi Michal,
>
> On 04/02/2014 09:01 PM, Michal Simek wrote:
> > On 04/02/2014 09:50 AM, Pankaj Dubey wrote:
> >> This patch corrects file path mentioned in file comment message.
> >>
> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@...sung.com>
> >> ---
> >> arch/arm/mach-exynos/platsmp.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-
> exynos/platsmp.c
> >> index 03e5e9f..d8d1555 100644
> >> --- a/arch/arm/mach-exynos/platsmp.c
> >> +++ b/arch/arm/mach-exynos/platsmp.c
> >> @@ -1,4 +1,4 @@
> >> -/* linux/arch/arm/mach-exynos4/platsmp.c
> >> +/* linux/arch/arm/mach-exynos/platsmp.c
> >> *
> >> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd.
> >> * http://www.samsung.com
> >>
> > Shouldn't you just remove it entirely?
> > I had the same file names in the whole microblaze tree
> > and some months/years later this was just broken everywhere.
> > That's why it is just easier to remove it entirely.
>
> Thanks for review and suggestion.
> Removing of file name makes more sense to me also.
> Will take care of this in some other files also under "mach-exynos"
> in next version of patch.
>
No, basically don't need it.
And Sachin/Tushar have posted it before, I didn't agree at that time though.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists