linux-kernel - Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACQ1gAg8N+Y1=dvkZcA_KyLudfSB_ueL1+LS4F=2F2TE_JwtGA@mail.gmail.com>
Date:	Thu, 3 Apr 2014 17:46:30 +0200
From:	Richard Genoud <richard.genoud@...il.com>
To:	Jakub Kiciński <moorray3@...pl>
Cc:	Ivo van Doorn <IvDoorn@...il.com>,
	Gertjan van Wingerde <gwingerde@...il.com>,
	Helmut Schaa <helmut.schaa@...glemail.com>,
	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rt2x00: BUG: remove double loop on REGISTER_BUSY_COUNT

2014-04-03 17:37 GMT+02:00 Jakub Kiciński <moorray3@...pl>:
> On Thu,  3 Apr 2014 16:12:07 +0200, Richard Genoud wrote:
>> rt2x00usb_register_read_lock() calls rt2x00usb_vendor_req_buff_lock()
>> that calls rt2x00usb_vendor_request() which is already looping up to
>> REGISTER_BUSY_COUNT times.
>>
>> So this loop is not needed.
>
> Not true.  rt2x00usb_vendor_request() busy-waits for usb_control_msg()
> to succeed, rt2x00usb_register_read_lock() busy-waits for the register
> field itself to become 0.
>
> Also, how would this be a BUG?

Ok, you're right.
Just forget about this patch...

Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/