linux-kernel - linux-3.14 nfsd regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Apr 2014 12:33:55 -0400
From:	Mark Lord <mlord@...ox.com>
To:	Albert Fluegel <af@....de>, "J. Bruce Fields" <bfields@...hat.com>
CC:	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: linux-3.14 nfsd regression

This commit from linux-3.14 breaks our NFS-root clients here:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6e14b46b91fee8a049b0940333ce13a820beaaa5

- *p++ = htonl((u32) stat->mode);
+ *p++ = htonl((u32) (stat->mode & S_IALLUGO));

Reverting the one-liner above (on the server) fixes it for us,
as does reverting back to linux-3.13.8 on the server.

The NFS-root clients are on PowerPC (big-endian) architecture,
running linux-3.12.16. The NFS server is on an Intel PC running linux-3.14.

ACL is completely disabled on server and client,
and we're using NFSv2/v3.  No support for v4.

I instrumented the function to see what other bits were being cleared
by the (stat->mode & S_IALLUGO) masking.  The results are attached.

Cheers
Mark

View attachment "11_revert_nfsxdr_to_fix_nfsroot.trace" of type "text/plain" (194603 bytes)