linux-kernel - Re: ks8851: reset on RX failure and TX timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140403.133203.1056561986987869608.davem@davemloft.net>
Date:	Thu, 03 Apr 2014 13:32:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Max.Nekludov@...ter.com
Cc:	torvalds@...ux-foundation.org, netdev@...r.kernel.org,
	sboyd@...eaurora.org, mjr@...wisc.edu, jiri@...nulli.us,
	linux-kernel@...r.kernel.org, trivial@...tcorp.com.au
Subject: Re: ks8851: reset on RX failure and TX timeout

From: "Nekludov, Max" <Max.Nekludov@...ter.com>
Date: Wed, 2 Apr 2014 06:31:23 +0000

> Electromagnetic noise can make device to not send TX interrupts.
> As result outgoing queue will be suspended forever.
> Also EMI can raise RX interrupt with zero value in KS_RXFC register.
> 
> Signed-off-by: Max Nekludov <Max.Nekludov@...ter.com>

We have a watchdog facility for TX timeouts, don't reinvent the wheel.

Implement ->ndo_tx_timeout() and set dev->watchdog_timeo appropriately.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/