lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 3 Apr 2014 20:42:08 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jimmy Li <coder.liss@...il.com>
Cc:	Joe Perches <joe@...ches.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Teodora Baluta <teobaluta@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Michael Gunselmann <michael.gunselmann@...dium.uni-erlangen.de>,
	Lisa Nguyen <lisa@...apiadmin.com>,
	Martin Hofmann <martin.hofmann@...dium.uni-erlangen.de>,
	Malcolm Priestley <tvboxspy@...il.com>,
	=?utf-8?B?VMO8bGluIMSwemVy?= 
	<tulinizer@...il.com>, Archana kumari <archanakumari959@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning

On Fri, Apr 04, 2014 at 12:32:29AM +0800, Jimmy Li wrote:
> Signed-off-by: Jimmy Li <coder.liss@...il.com>

You dropped the commit message which said which sparse warnings were
fixed.  It should say something about the other cleanups as well. Also
the subject prefix isn't right.  Use:

[PATCH v3] Staging: vt6655: iwctl.c: fix a sparse warning

Or something.  "drivers/" doesn't add any information.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists