linux-kernel - Re: [PATCH] staging : panel : fix checkpatch warnings (linux-next)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Apr 2014 20:52:52 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	armand.bastien@...oste.net
Cc:	willy@...a-x.org, gregkh@...uxfoundation.org,
	monamagarwal123@...il.com, jake.champlin.27@...il.com,
	arnd@...db.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging : panel : fix checkpatch warnings (linux-next)

On Thu, Apr 03, 2014 at 06:59:09PM +0200, armand.bastien@...oste.net wrote:
> This patch fixes "Missing a blank line after declarations" checkpatch warning in panel.c.
> 
> 
> Signed-off-by: "Bastien Armand <armand.bastien@...oste.net>"

Fix your email client to use the proper From header.  The signed-off-by
format is wrong as well (extra quotes).  The subject should be:

[PATCH] staging: panel: add blank lines after declarations

The original had extra space characters.  Don't put "(linux-next)" in
the permanent log.  Be as specific as you can in roughly 52 characters.

Otherwise it looks ok.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/