linux-kernel - Re: [RFC] quiet checkpatch style recommendation about no spaces around bitfield :

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Apr 2014 19:28:21 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Joe Perches <joe@...ches.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Rocco Folino <lordzen87@...il.com>, aaro.koskinen@....fi,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] quiet checkpatch style recommendation about no spaces
 around bitfield :

On Mon, Mar 31, 2014 at 01:56:28PM -0700, Andrew Morton wrote:
> On Mon, 31 Mar 2014 08:31:38 -0700 Joe Perches <joe@...ches.com> wrote:
> 
> > > > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> > > >  	 *	* 1'b1: Unmask the interrupt assertion to the application.
> > > >  	 */
> > > >  	struct cvmx_usbcx_gahbcfg_s {
> > > > -		uint32_t reserved_9_31	: 23;
> > > > -		uint32_t ptxfemplvl	: 1;
> > > > -		uint32_t nptxfemplvl	: 1;
> > > > -		uint32_t reserved_6_6	: 1;
> > > > -		uint32_t dmaen		: 1;
> > > > -		uint32_t hbstlen	: 4;
> > > > -		uint32_t glblintrmsk	: 1;
> > > > +		uint32_t reserved_9_31:23;
> > > > +		uint32_t ptxfemplvl:1;
> > > > +		uint32_t nptxfemplvl:1;
> > > > +		uint32_t reserved_6_6:1;
> > > > +		uint32_t dmaen:1;
> > > > +		uint32_t hbstlen:4;
> > > > +		uint32_t glblintrmsk:1;
> > > >  	} s;
> > > The warning here is:
> > > ERROR: spaces prohibited around that ':' (ctx:WxW)
> > > I have done a kernel wide search for these warnings
> > 
> > Really?  How?
> > 
> > >  and I think we
> > > should disable this warning.  It has too many false positives like this.
> > 
> > It does seem a bit noisy to me too.
> > 
> > Andy?  Andrew?
> 
> I suspect we don't use bitfields enough for a particular style to have
> emerged.  Personally I think the above patch made the code harder to
> read, so...

Yeah it seems the predominant style would trigger the warning.  So turn
it off.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/