linux-kernel - Re: [PATCH] fs: Don't return 0 from get_anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533DC2CC.5090408@zytor.com>
Date:	Thu, 03 Apr 2014 13:21:32 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Thomas Bächler <thomas@...hlinux.org>,
	tj@...nel.org
CC:	d@...conindy.com, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, P@...igbrady.com,
	alexandre.f.demers@...il.com, "3.14" <stable@...r.kernel.org>
Subject: Re: [PATCH] fs: Don't return 0 from get_anon_bdev

On 04/03/2014 12:49 PM, Thomas Bächler wrote:
> Commit 9e30cc9595303b27b48 removed an internal mount. This
> has the side-effect that rootfs now has FSID 0. Many
> userspace utilities assume that st_dev in struct stat
> is never 0, so this change breaks a number of tools in
> early userspace.
> 
> Since we don't know how many userspace programs are affected,
> make sure that FSID is at least 1.
> 
> References: http://article.gmane.org/gmane.linux.kernel/1666905
> References: http://permalink.gmane.org/gmane.linux.utilities.util-linux-ng/8557
> Cc: 3.14 <stable@...r.kernel.org>
> Signed-off-by: Thomas Bächler <thomas@...hlinux.org>
> ---
>  fs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: H. Peter Anvin <hpa@...or.com>

It is worth noting that zero has been documented as a null device number
since at least 1995, probably more like 1993.

	-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/