linux-kernel - Re: [PATCH 1/3] regulator: core: Add of_node_get to of_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140403215027.GD14763@sirena.org.uk>
Date:	Thu, 3 Apr 2014 22:50:27 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH 1/3] regulator: core: Add of_node_get to
 of_regulator_match

On Thu, Apr 03, 2014 at 03:32:15PM +0100, Charles Keepax wrote:
> Currently, of_regulator_match does not increment the reference count of
> the of_nodes it takes new references to. This could cause the node
> pointer held to be invalid, by the time it is passed to the regulator
> core. This patchs adds an of_node_get when we copy each of_node pointer
> into the match structure.

Applied all, thanks.  You just made all users of of_regulator_match()
buggy - I'm assuming you're going to be fixing that!  :P

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)