[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 4 Apr 2014 12:15:27 -0400
From: Murali Karicheri <m-karicheri2@...com>
To: Lucas Stach <l.stach@...gutronix.de>
CC: Arnd Bergmann <arnd@...db.de>, "xobs@...agi.com" <xobs@...agi.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Richard Zhu <r65037@...escale.com>,
Kukjin Kim <kgene.kim@...sung.com>,
Mohit Kumar <mohit.kumar@...com>,
Jingoo Han <jg1.han@...sung.com>,
"Shilimkar, Santosh" <santosh.shilimkar@...com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based
on designware core driver
On 4/3/2014 4:32 AM, Lucas Stach wrote:
> Am Mittwoch, den 02.04.2014, 13:17 -0400 schrieb Murali Karicheri:
>> Arnd,
>>
>> Thanks for reviewing the RFC patch. Please see below my response.
>>
>> On 3/25/2014 3:44 AM, Arnd Bergmann wrote:
>>> On Monday 24 March 2014 20:35:26 Murali Karicheri wrote:
> [...]
>>>> + ks_pcie->clk = devm_clk_get(&pdev->dev, "pcie");
>>>> + if (IS_ERR(ks_pcie->clk)) {
>>>> + dev_err(&pdev->dev, "Failed to get pcie rc clock\n");
>>>> + return PTR_ERR(ks_pcie->clk);
>>>> + }
>>>> + ret = clk_prepare_enable(ks_pcie->clk);
>>>> + if (ret)
>>>> + return ret;
>>> Could you move the clock handling into the generic dw-pcie code?
>> Could be. But currently only pci-exynos.c is using a clock name
>> "pcie".pci-imx6.c uses pcie_axi" and
>> will have to be fixed so that we can move this code to the generic
>> dw-pcie code. Sean Cross is the
>> author for pci-imx6.c.
>>
>> Sean,
>>
>> Is "pcie_axi" is the pcie hw clock? If so, can you rename this to "pcie"
>> so that my patch can move the
>> clock handling code to pcie designware code?
>>
> My series "i.MX6 PCIe binding change and MSI support" already changes
> the clock name. So we could consolidate the clock handling once this is
> in. Only difference is that the i.MX6 needs an additional PHY clock.
>
> Regards,
> Lucas
Lucas,
Thanks. I will send a patch for this.
Murali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists