[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 04 Apr 2014 07:38:00 +0200
From: Michal Simek <monstr@...str.eu>
To: Harini Katakam <harinikatakamlinux@...il.com>
CC: Mark Brown <broonie@...nel.org>,
Punnaiah Choudary Kalluri
<punnaiah.choudary.kalluri@...inx.com>,
Grant Likely <grant.likely@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>, linux-spi@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
Michal Simek <michal.simek@...inx.com>,
Punnaiah Choudary <kpc528@...il.com>,
punnaiah choudary kalluri <kalluripunnaiahchoudary@...il.com>,
Punnaiah Choudary Kalluri <punnaia@...inx.com>
Subject: Re: [PATCH 1/2] devicetree: Add devicetree bindings documentation
for Zynq Quad SPI
Hi Mark and Harini,
On 04/04/2014 05:01 AM, Harini Katakam wrote:
> Hi Mark,
>
> On Fri, Apr 4, 2014 at 2:31 AM, Mark Brown <broonie@...nel.org> wrote:
>> On Thu, Apr 03, 2014 at 10:33:06PM +0530, Punnaiah Choudary Kalluri wrote:
>>
>>> +Optional properties:
>>> +- num-cs : Number of chip selects used.
>>
>> What does this translate into?
>>
>>> + num-cs = /bits/ 16 <1>;
>>
>> Why the odd specification in the example - why not just specify it as a
>> number?
>
> Same as discussed on SPI cadence thread.
I have discussed this briefly with Rob and it is more up to Mark
if he wants to have this with 16bit width or not. I expect that
"num-cs" is getting to be shared across spi drivers
and maybe in near future you will move "num-cs" of probe to spi core
that's why it should stay 32bit for easier integration.
I have asked Harini some weeks ago to try to do it just with
of_property_read_u16 because you can directly setup
master->num_chipselect and you don't need to read it as u32
and saving to u16.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)
Powered by blists - more mailing lists