linux-kernel - Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140405220927.GA29836@kroah.com>
Date:	Sat, 5 Apr 2014 15:09:27 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Camille Begue <camille.begue44@...il.com>
Cc:	devel@...verdev.osuosl.org, Ian Abbott <abbotti@....co.uk>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning

On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote:
> Wrap lines > 80 columns.
> This patch is part of eudyptula challenge
> 
> Signed-off-by: Camille Begue <camille.begue44@...il.com>
> ---
>  drivers/staging/comedi/comedi_fops.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ea6dc36..0f05e87 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
>  	s = &dev->subdevices[cmd->subdev];
>  
>  	if (s->type == COMEDI_SUBD_UNUSED) {
> -		dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> +		dev_dbg(dev->class_dev,
> +			"%d not valid subdevice\n",
> +			cmd->subdev);

Why did you split this into 3 lines, it only needs to be 2 like this:
		dev_dbg(dev->class_dev, "%d not valid subdevice\n",
			cmd->subdev);

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/