linux-kernel - Re: [PATCH 2/2] ttyprintk: Allow built as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1396696534.11212.32.camel@lapuh>
Date:	Sat, 05 Apr 2014 13:15:34 +0200
From:	Samo Pogačnik <samo_pogacnik@....net>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>, Arnd Bergmann <arnd@...db.de>,
	Jean Delvare <jdelvare@...e.de>,
	Struan Bartlett <struan.bartlett@...il.com>,
	Andreas Schwab <schwab@...ux-m68k.org>,
	gnomes@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ttyprintk: Allow built as a module

Dne 03.04.2014 (čet) ob 08:13 +0200 je Takashi Iwai napisal(a):
> At Wed, 2 Apr 2014 12:32:22 -0700,
> Greg Kroah-Hartman wrote:
> > 
> > On Wed, Apr 02, 2014 at 12:29:42PM +0200, Takashi Iwai wrote:
> > > The driver is well written to be used as a module, just the exit call
> > > is missing.
> > > 
> > > Signed-off-by: Takashi Iwai <tiwai@...e.de>
> > > ---
> > >  drivers/char/Kconfig     |  2 +-
> > >  drivers/char/ttyprintk.c | 13 ++++++++++++-
> > >  2 files changed, 13 insertions(+), 2 deletions(-)
> > 
> > There was some reason we didn't do this back when the code was accepted,
> > but I really can't remember why.
> > 
> > If you have tested this out, I don't have any objections to taking these
> > patches, thanks.
> 
> The module worked fine with my quick tests (load/unload/feed something
> via /dev/ttyprintk), at least.  But it'd be helpful if anyone
> remembers and clarifies.
> 
My initial requirement was to be able to use this functionality as soon
as possible at the beginning of user-space initialisation, so i never
thought of the ttyprintk code being loaded afterwards as module. Also
nobody brought modularisation subject to the table during code
acceptance.

> 
> thanks,
> 
> Takashi

regards, Samo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/