linux-kernel - Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 Apr 2014 12:02:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Joel Pelaez Jorge <joelpelaez@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Silvan Jegen <s.jegen@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

On Sun, 2014-04-06 at 14:00 -0500, Joel Pelaez Jorge wrote:
> El 06/04/14 13:49, Joe Perches escribió:
> > On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote:
[]
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
[]
> >> -static struct iw_statistics *r8192_get_wireless_stats(struct net_device
> >> *dev)
> >> +struct iw_statistics *r8192_get_wireless_stats(struct net_device *dev)
> >>    {
> >>    	struct r8192_priv *priv = rtllib_priv(dev);
> >>    	struct rtllib_device *ieee = priv->rtllib;
> >
> > As far as I can tell, there's no reason this should
> > be declared in the .h file and it should stay static
> > and not be exposed at all.
[]
> In the source "rtl_core.c" is possible to use the symbol
> r8192_get_wireless_stats, if WIRELESS_EXT has specifics values.
> 
> Although this scenario is unlikely to happen, is better prepare
> this code for it.

Huh?  This makes no sense to me.
Maybe you can expand a bit here.

> Also, a better way will be delete 'extern' reference to symbol
> in header file and source file.

That's what I said.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/