linux-kernel - Re: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdU2izuWReTnuMxz=o7HYNuonYsvekAzd_RU7Qec7f0oug@mail.gmail.com>
Date:	Sun, 6 Apr 2014 15:17:05 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Insop Song <insop.song@...nspeed.com>
Subject: Re: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

On Tue, Mar 25, 2014 at 4:48 PM, Arnd Bergmann <arnd@...db.de> wrote:
> We specifically build the kernel with -Werror=date-time to detect
> such macros, which gives us this error:
>
> gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
>   pr_info("built at %s UTC\n", __TIMESTAMP__);

Worse, gcc 4.1.2 doesn't seem to understand __TIMESTAMP__:

drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_fpgaboot_init’:
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: ‘__TIMESTAMP__’
undeclared (first use in this function)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: (Each undeclared
identifier is reported only once
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: for each
function it appears in.)

> The obvious fix is to remove the printk output line.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> index 89bc84d..7506900 100644
> --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> @@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
>         r = -1;
>
>         pr_info("FPGA DOWNLOAD --->\n");
> -       pr_info("built at %s UTC\n", __TIMESTAMP__);
>
>         pr_info("FPGA image file name: %s\n", file);
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/