linux-kernel - Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Apr 2014 15:37:41 +0300
From:	Matei Oprea <eu@...eamatei.ro>
To:	jbottomley@...allels.com
Cc:	james.smart@...lex.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Matei Oprea <eu@...eamatei.ro>,
	ROSEdu Kernel Community <firefly@...ts.rosedu.org>
Subject: Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

Any comments on this ?
ᐧ

On Tue, Mar 18, 2014 at 10:51 PM, Matei Oprea <eu@...eamatei.ro> wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
>
> Signed-off-by: Matei Oprea <eu@...eamatei.ro>
> Cc: ROSEdu Kernel Community <firefly@...ts.rosedu.org>
> ---
>  drivers/scsi/lpfc/lpfc_init.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 68c94cc..0a51ca5 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -4731,9 +4731,9 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
>         }
>
>         if (!phba->sli.ring)
> -               phba->sli.ring = (struct lpfc_sli_ring *)
> -                       kzalloc(LPFC_SLI3_MAX_RING *
> +               phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
>                         sizeof(struct lpfc_sli_ring), GFP_KERNEL);
> +
>         if (!phba->sli.ring)
>                 return -ENOMEM;
>
> --
> 1.7.9.5
>



-- 
Oprea Matei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/