linux-kernel - Re: [PATCH v4] ext4: initialize multi-block allocator before checking block descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140407143715.GB25478@thunk.org>
Date:	Mon, 7 Apr 2014 10:37:15 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Azat Khuzhin <a3at.mail@...il.com>
Cc:	linux-ext4@...r.kernel.org,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] ext4: initialize multi-block allocator before
 checking block descriptors

On Sat, Apr 05, 2014 at 07:48:36PM +0400, Azat Khuzhin wrote:
> With EXT4FS_DEBUG ext4_count_free_clusters() will call
> ext4_read_block_bitmap() without s_group_info initialized, so we need to
> initialize multi-block allocator before.
> 
> And dependencies that must be solved, to allow this:
> - multi-block allocator needs in group descriptors
> - need to install s_op before initializing multi-block allocator,
>   because in ext4_mb_init_backend() new inode is created.
> - initialize number of group desc blocks (s_gdb_count) otherwise
>   number of clusters returned by ext4_free_clusters_after_init() is not correct.
>   (see ext4_bg_num_gdb_nometa())

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/