linux-kernel - Re: [PATCH 1/2] mm/compaction: clean up unused code lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5342B8CC.9020009@suse.cz>
Date:	Mon, 07 Apr 2014 16:40:12 +0200
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Heesub Shin <heesub.shin@...sung.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Mel Gorman <mgorman@...e.de>,
	Dongjun Shin <d.j.shin@...sung.com>,
	Sunghwan Yun <sunghwan.yun@...sung.com>
Subject: Re: [PATCH 1/2] mm/compaction: clean up unused code lines

On 04/03/2014 10:57 AM, Heesub Shin wrote:
> This commit removes code lines currently not in use or never called.
>
> Signed-off-by: Heesub Shin <heesub.shin@...sung.com>
> Cc: Dongjun Shin <d.j.shin@...sung.com>
> Cc: Sunghwan Yun <sunghwan.yun@...sung.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>   mm/compaction.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 9635083..1ef9144 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -208,12 +208,6 @@ static bool compact_checklock_irqsave(spinlock_t *lock, unsigned long *flags,
>   	return true;
>   }
>
> -static inline bool compact_trylock_irqsave(spinlock_t *lock,
> -			unsigned long *flags, struct compact_control *cc)
> -{
> -	return compact_checklock_irqsave(lock, flags, false, cc);
> -}
> -
>   /* Returns true if the page is within a block suitable for migration to */
>   static bool suitable_migration_target(struct page *page)
>   {
> @@ -728,7 +722,6 @@ static void isolate_freepages(struct zone *zone,
>   			continue;
>
>   		/* Found a block suitable for isolating free pages from */
> -		isolated = 0;
>
>   		/*
>   		 * As pfn may not start aligned, pfn+pageblock_nr_page
> @@ -1160,9 +1153,6 @@ static void __compact_pgdat(pg_data_t *pgdat, struct compact_control *cc)
>   			if (zone_watermark_ok(zone, cc->order,
>   						low_wmark_pages(zone), 0, 0))
>   				compaction_defer_reset(zone, cc->order, false);
> -			/* Currently async compaction is never deferred. */
> -			else if (cc->sync)
> -				defer_compaction(zone, cc->order);
>   		}
>
>   		VM_BUG_ON(!list_empty(&cc->freepages));
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/