linux-kernel - Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 07 Apr 2014 16:44:43 +0200
From:	Jonas Hahnfeld <hahnjo@...njo.de>
To:	Stefan Lippers-Hollmann <s.L-H@....de>
Cc:	driverdev-devel@...uxdriverproject.org,
	Josh Triplett <josh@...htriplett.org>,
	devel@...verdev.osuosl.org,
	Andreea-Cristina Bernat <bernat.ada@...il.com>,
	Andrea Merello <andrea.merello@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ana Rey <anarey@...il.com>, linux-kernel@...r.kernel.org,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Teodora Baluta <teobaluta@...il.com>,
	Dan LaManna <dan.lamanna@...il.com>,
	Pablo Neira Ayuso <pablo@...monks.org>
Subject: Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static

Am Montag, den 07.04.2014, 01:34 +0000 schrieb Stefan Lippers-Hollmann:
> Hi
> 
> On Sunday 06 April 2014, Josh Triplett wrote:
> > On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> > > This patch solves some sparse warnings about "symbol [...] was not
> > > declared. Should it be static?" by including the correct header files.
> > > 
> > > Signed-off-by: Jonas Hahnfeld <hahnjo@...njo.de>
> > 
> > Reviewed-by: Josh Triplett <josh@...htriplett.org>
> [...]
> 
> Given that that rtl8187se support has already been merged mainline (for
> 3.15-rc1) into the existing rtl8180 (soon to be renamed to rtl818x) 
> driver, wouldn't it make more sense to remove 
> drivers/staging/rtl8187se/ rather than trying to fixing it?
> 
> commit 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
> Author: Andrea Merello <andrea.merello@...il.com>
> Date:   Wed Mar 26 21:04:23 2014 +0100
> 
>     rtl8180: enable rtl8187se support
>     
>     Finally make rtl8187se works (hopefylly).
>     This patch adds PCI ID for rtl8187, updates copyright notes and
>     updates MODULE_DESCRIPTION.
>     
>     Signed-off-by: Andrea Merello <andrea.merello@...il.com>
>     Signed-off-by: John W. Linville <linville@...driver.com>
> 
> Regards
> 	Stefan Lippers-Hollmann

Yes, probably. Sorry, didn't know that, hadn't looked after this!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/