linux-kernel - Re: f2fs: kernel BUG at fs/f2fs/segment.h:543

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1396842028.24638.4.camel@kjgkr>
Date:	Mon, 07 Apr 2014 12:40:28 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Sasha Levin <sasha.levin@...cle.com>
Cc:	linux-f2fs-devel@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: f2fs: kernel BUG at fs/f2fs/segment.h:543

2014-04-06 (일), 21:55 -0400, Sasha Levin:
> On 04/06/2014 09:20 PM, Jaegeuk Kim wrote:
> > Hi,
> > 
> > Thank you for the report.
> > 
> > If possible, could you share fsck.f2fs or dump.f2fs on the corrupted
> > partition?
> > 
> > Otherwise, how about this?
> > # fdisk /dev/sdx
> >> > p
> 
> Hey Jaegeuk,
> 
> Unfortunately it was a temporary filesystem inside the fuzzer that has
> gone away as soon as the kernel died, so I don't have access to it.

Got it.
Then, just for sure, if it is reproducible, could you test f2fs with the
following patch?
Thanks,

>From 84f80a126458eeeaa3c4ebcecfb6908f7d22b214 Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim <jaegeuk.kim@...sung.com>
Date: Mon, 7 Apr 2014 12:37:39 +0900
Subject: [PATCH] test

Signed-off-by: Jaegeuk Kim <jaegeuk.kim@...sung.com>
---
 fs/f2fs/segment.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index 7091204..d9cf06e 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -540,6 +540,11 @@ static inline void verify_block_addr(struct
f2fs_sb_info *sbi, block_t blk_addr)
 	block_t total_blks = sm_info->segment_count <<
sbi->log_blocks_per_seg;
 	block_t start_addr = sm_info->seg0_blkaddr;
 	block_t end_addr = start_addr + total_blks - 1;
+	if (blk_addr < start_addr) {
+		f2fs_msg(sbi->sb, KERN_ERR,
+			"blk_addr: %ld, start: %ld, end: %ld",
+			blk_addr, start_addr, end_addr);
+	}
 	BUG_ON(blk_addr < start_addr);
 	BUG_ON(blk_addr > end_addr);
 }
-- 
1.8.4.474.g128a96c


-- 
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/