linux-kernel - Re: [PATCH 2/4] perf, kmem: Utilize the new generic cpunode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 7 Apr 2014 14:18:22 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	acme@...stprotocols.net, LKML <linux-kernel@...r.kernel.org>,
	jmario@...hat.com, fowles@...each.com,
	Li Zefan <lizf@...fujitsu.com>
Subject: Re: [PATCH 2/4] perf, kmem: Utilize the new generic cpunode_map

On Sun, Apr 06, 2014 at 02:21:26PM +0200, Jiri Olsa wrote:
> On Mon, Mar 31, 2014 at 10:42:30PM -0400, Don Zickus wrote:
> 
> SNIP
> 
> > > > -#define PATH_SYS_NODE	"/sys/devices/system/node"
> > > > -
> > > > -static int init_cpunode_map(void)
> > > > -{
> > > > -	FILE *fp;
> > > > -	int i, err = -1;
> > > > -
> > > > -	fp = fopen("/sys/devices/system/cpu/kernel_max", "r");
> > > 
> > > so the factored code from previous patches now reads
> > > the max_cpu_num value from:
> > >   /sys/devices/system/cpu/possible
> > > 
> > > is this intentional?
> > 
> > Yeah, I was trying to save bits.  No need to allocate for 5100 cpus when
> > only 128 are used.
> > 
> > > 
> > > I think we want to have separate patches for code changes
> > > and for changing the file with some comment.
> > 
> > So you want me to split the previous patch into two.  One for code
> > movement, the other for the path change?
> 
> I think thats the proper way.. single logic change for patch

Hmm, the whole change is getting completely messy with the breakdown of
common functions, renames, use of internal functions, etc...  I'll just
break out the small change (kernel_max -> possible) from that mess.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/