linux-kernel - Re: [PATCH 3.2 17/18] cifs: ensure that uncached writes handle unmapped areas correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1396898056.8206.32.camel@deadeye.wl.decadent.org.uk>
Date:	Mon, 07 Apr 2014 20:14:16 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Raphael Geissert <geissert@...ian.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, Jeff Layton <jlayton@...hat.com>,
	Steve French <smfrench@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Pavel Shilovsky <piastry@...rsoft.ru>, 741958@...s.debian.org
Subject: Re: [PATCH 3.2 17/18] cifs: ensure that uncached writes handle
 unmapped areas correctly

On Mon, 2014-04-07 at 15:45 +0200, Raphael Geissert wrote:
> Hi,
> 
> On 7 April 2014 03:41, Ben Hutchings <ben@...adent.org.uk> wrote:
> > On Mon, 2014-04-07 at 00:35 +0100, Ben Hutchings wrote:
> >> 3.2.57-rc1 review patch.  If anyone has any objections, please let me know.
> > [...]
> > --- a/fs/cifs/file.c
> > +++ b/fs/cifs/file.c
> [...]
> > +               /*
> > +                * i + 1 now represents the number of pages we actually used in
> > +                * the copy phase above.
> > +                */
> > +               npages = min(npages, i + 1);
> 
> I'm having trouble understanding why min() is needed here. It
> shouldn't harm either, but I find it confusing.

Because in the case where no error occurred, the comment is not true:
i == npages and npages have been used.  The loop used upstream works,
but it seemed a bit silly to use a loop here.

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)