lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 Apr 2014 15:45:34 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Dave Hansen <dave.hansen@...el.com> Cc: Madhavan Srinivasan <maddy@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-mm@...ck.org, linux-arch@...r.kernel.org, x86@...nel.org, paulus@...ba.org, kirill.shutemov@...ux.intel.com, rusty@...tcorp.com.au, akpm@...ux-foundation.org, riel@...hat.com, mgorman@...e.de, ak@...ux.intel.com, peterz@...radead.org, mingo@...nel.org Subject: Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/ On Fri, 2014-04-04 at 09:18 -0700, Dave Hansen wrote: > On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote: > > This patch creates infrastructure to move the FAULT_AROUND_ORDER > > to arch/ using Kconfig. This will enable architecture maintainers > > to decide on suitable FAULT_AROUND_ORDER value based on > > performance data for that architecture. Patch also adds > > FAULT_AROUND_ORDER Kconfig element in arch/X86. > > Please don't do it this way. > > In mm/Kconfig, put > > config FAULT_AROUND_ORDER > int > default 1234 if POWERPC > default 4 > > The way you have it now, every single architecture that needs to enable > this has to go put that in their Kconfig. That's madness. This way, > you only put it in one place, and folks only have to care if they want > to change the default to be something other than 4. Also does it have to be a constant ? Maddy here tested on our POWER servers. The "Sweet spot" value might be VERY different on an embedded chip or even on a future generation of server chip. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists