linux-kernel - Re: [PATCH 08/15 V3] perf, c2c: Add stats to track data source bits and cpu to node maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eh18w8ij.fsf@sejong.aot.lge.com>
Date:	Tue, 08 Apr 2014 17:05:56 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Don Zickus <dzickus@...hat.com>
Cc:	acme@...stprotocols.net, LKML <linux-kernel@...r.kernel.org>,
	jolsa@...hat.com, jmario@...hat.com, fowles@...each.com,
	peterz@...radead.org, eranian@...gle.com, andi.kleen@...el.com
Subject: Re: [PATCH 08/15 V3] perf, c2c: Add stats to track data source bits and cpu to node maps

On Mon, 24 Mar 2014 15:36:59 -0400, Don Zickus wrote:
> This patch adds a bunch of stats that will be used later in post-processing
> to determine where and with what frequency the HITMs are coming from.
>
> Most of the stats are decoded from the data source response.  Another
> piece of the stats is tracking which cpu the record came in on.
>
> Credit to Dick Fowles for determining which bits are important and how to
> properly track them.  Ported to perf by me.
> @@ -187,6 +354,14 @@ static int perf_c2c__process_load_store(struct perf_c2c *c2c,
>  		goto out_mem;
>  	}
>  
> +	err = c2c_decode_stats(&c2c->stats, he);
> +	if (err < 0) {
> +		err = 0;
> +		rb_erase(&he->rb_node_in, c2c->hists.entries_in);
> +		free(he);

Please use hist_entry__free() to free he->mem_info also.

Thanks,
Namhyung


> +		goto out;
> +	}
> +
>  	c2c->hists.stats.total_period += cost;
>  	hists__inc_nr_events(&c2c->hists, PERF_RECORD_SAMPLE);
>  	return err;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/