linux-kernel - Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5343ADFA.7010703@realtek.com>
Date:	Tue, 8 Apr 2014 16:06:18 +0800
From:	Roger <rogerable@...ltek.com>
To:	Lee Jones <lee.jones@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Chris Ball <chris@...ntf.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Alex Dubov <oakad@...oo.com>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	<linux-kernel@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<driverdev-devel@...uxdriverproject.org>,
	<wei_wang@...lsil.com.cn>, <micky_ching@...lsil.com.cn>
Subject: Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver


On 04/02/2014 11:16 PM, Lee Jones wrote:
> On Tue, 01 Apr 2014, Andrew Morton wrote:
>
>> On Tue, 1 Apr 2014 11:20:32 +0800 Roger <rogerable@...ltek.com> wrote:
>>
>>> On 03/25/2014 06:44 PM, rogerable@...ltek.com wrote:
>>>> From: Roger Tseng <rogerable@...ltek.com>
>>>>
>>>> Realtek USB memstick host driver provides memstick host support based on the
>>>> Realtek USB card reader MFD driver.
>>>>
>>>> Signed-off-by: Roger Tseng <rogerable@...ltek.com>
>>>> ---
>>>>    drivers/memstick/host/Kconfig       |  10 +
>>>>    drivers/memstick/host/Makefile      |   1 +
>>>>    drivers/memstick/host/rtsx_usb_ms.c | 839 ++++++++++++++++++++++++++++++++++++
>>>>    3 files changed, 850 insertions(+)
>>>>    create mode 100644 drivers/memstick/host/rtsx_usb_ms.c
>>> Hi Andrew,
>>>
>>> Since I'll have to send next revision(v6, to modify patch 1/3) and
>>> you've commented v4, would you also comment or Ack the 3/3 of this one?
>>> This should save one revision for me to make any necessary change.
>>
>> It looks OK to my inexpert eye.  It would be better if Maxim and/or Alex
>> could review the code.  If that doesn't happen then I guess the best we
>> can do is to go ahead and merge it.  Have you worked out via which tree
>> the patches will be merged?
>
> I'll be happy to take the set if one of the subsystem experts would be
> kind enough to cast an eye over it.
>
> Maxim, Alex?
>
Lee,

When I prepare my next submission, I found a previous version of this 
patch set(and only the 1/3 'mfd' part)  seems to be merged in the 
following commit:

commit e5744abb2fa3629aa5a94e21ca1eae32ff2fe00b
Merge: c29aa15 2d28ca7
Author: Linus Torvalds <torvalds@...ux-foundation.org>
Date:   Mon Apr 7 10:24:18 2014 -0700

     Merge tag 'mfd-for-linus-3.15' of 
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd

Is there any chance to revert it? Or what can I do to help current 
situation?

note: the merged commit:
commit 730876be256603b4ee7225a125467d97a7ce9060
Author: Roger Tseng <rogerable@...ltek.com>
Date:   Wed Feb 12 18:00:36 2014 +0800

     mfd: Add realtek USB card reader driver


Best regards,
Roger Tseng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/