linux-kernel - Re: [PATCH] ARC: Remove ISS_SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C2D7FE5348E1B147BCA15975FBA230751AC602@IN01WEMBXA.internal.synopsys.com>
Date:	Tue, 8 Apr 2014 09:18:04 +0000
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARC: Remove ISS_SMP_EXTN entirely

Hi Paul,

On Tuesday 08 April 2014 02:26 PM, Paul Bolle wrote:
> The Kconfig symbol ARC_HAS_COH_RTSC was removed in v3.13. The Kconfig
> entry for ISS_SMP_EXTN still had a select for that symbol. That select
> was just removed in commit d345ea2892ae ("ARC: Remove
> ARC_HAS_COH_RTSC").
>
> But selecting ARC_HAS_COH_RTSC was the only thing ISS_SMP_EXTN ever
> did. That means that since v3.13 setting ISS_SMP_EXTN was effectively a
> nop anyhow. So ISS_SMP_EXTN can as well be removed entirely.

There's obvious bitrot here - however this code is not dead yet !
I have a unpushed fix which uses this Kconfig item.

diff --git a/arch/arc/plat-arcfpga/Makefile b/arch/arc/plat-arcfpga/Makefile
index a44e22ebc1b7..4d1bddc34b5b 100644
--- a/arch/arc/plat-arcfpga/Makefile
+++ b/arch/arc/plat-arcfpga/Makefile
@@ -9,4 +9,4 @@
 KBUILD_CFLAGS  += -Iarch/arc/plat-arcfpga/include
 
 obj-y := platform.o irq.o
-obj-$(CONFIG_SMP)              += smp.o
+obj-$(CONFIG_ISS_SMP_EXTN)             += smp.o

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/