[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <14553349.srUCJdXInT@vostro.rjw.lan>
Date: Tue, 08 Apr 2014 14:11:59 +0200
From: "Rafael J. Wysocki" <rjw@...ysocki.net>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: linaro-kernel@...ts.linaro.org, cpufreq@...r.kernel.org,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
lxoliva@...la.org
Subject: Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static
On Wednesday, April 02, 2014 10:14:24 AM Viresh Kumar wrote:
> Earlier commit:
> commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656
> Author: Viresh Kumar <viresh.kumar@...aro.org>
> Date: Thu Jan 9 20:38:43 2014 +0530
>
> cpufreq: introduce cpufreq_generic_get() routine
>
> did some changes to driver and by mistake made cpuclk as a 'static' local
> variable, which wasn't actually required. Fix it.
>
> Reported-by: Alexandre Oliva <lxoliva@...la.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
Queued up for the next pull request, thanks!
> ---
> drivers/cpufreq/loongson2_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> index a3588d61..f0bc31f 100644
> --- a/drivers/cpufreq/loongson2_cpufreq.c
> +++ b/drivers/cpufreq/loongson2_cpufreq.c
> @@ -69,7 +69,7 @@ static int loongson2_cpufreq_target(struct cpufreq_policy *policy,
>
> static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy)
> {
> - static struct clk *cpuclk;
> + struct clk *cpuclk;
> int i;
> unsigned long rate;
> int ret;
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists