linux-kernel - Re: [PATCH V2 1/4] cpufreq: ia64: don't set .driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2698524.P4nWCs3Rzq@vostro.rjw.lan>
Date:	Tue, 08 Apr 2014 14:14:59 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linaro-kernel@...ts.linaro.org, cpufreq@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	srivatsa.bhat@...ux.vnet.ibm.com, ego@...ux.vnet.ibm.com,
	svaidy@...ux.vnet.ibm.com, l.majewski@...sung.com
Subject: Re: [PATCH V2 1/4] cpufreq: ia64: don't set .driver_data to index

On Friday, March 28, 2014 07:11:44 PM Viresh Kumar wrote:
> .driver_data field is only required to be filled if drivers want to preserve
> some data in there which they can use according to the value of .frequency
> field. But this driver isn't using this field at all, but just setting it equal
> to the index value. Which isn't required. Fix it.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

All four queued up for the next pull request, thanks!

> ---
> V1->V2: No Change
> 
> Hi Rafael,
> 
> To avoid confusion I am sending all related cpufreq patches again.
> 
>  drivers/cpufreq/ia64-acpi-cpufreq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index a22b5d1..beb191b 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -275,7 +275,6 @@ acpi_cpufreq_cpu_init (
>  	/* table init */
>  	for (i = 0; i <= data->acpi_data.state_count; i++)
>  	{
> -		data->freq_table[i].driver_data = i;
>  		if (i < data->acpi_data.state_count) {
>  			data->freq_table[i].frequency =
>  			      data->acpi_data.states[i].core_frequency * 1000;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/