linux-kernel - Re: [PATCH v4] Staging: vt6655: iwctl.c: fix a sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396961103.2812.4.camel@joe-AO722>
Date:	Tue, 08 Apr 2014 05:45:03 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jimmy Li <coder.liss@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Teodora Baluta <teobaluta@...il.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Michael Gunselmann <michael.gunselmann@...dium.uni-erlangen.de>,
	Lisa Nguyen <lisa@...apiadmin.com>,
	Martin Hofmann <martin.hofmann@...dium.uni-erlangen.de>,
	Malcolm Priestley <tvboxspy@...il.com>,
	=?utf-8?B?VMO8bGluIMSwemVy?= 
	<tulinizer@...il.com>, Archana kumari <archanakumari959@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] Staging: vt6655: iwctl.c: fix a sparse warning

On Tue, 2014-04-08 at 20:36 +0800, Jimmy Li wrote:
> fix a sparse warning and do some clean up.
> 
> Signed-off-by: Jimmy Li <coder.liss@...il.com>

The --- line should go here

> v1 fix a sparse warning.
> 	(iwctl.c:1846:35: expected restricted gfp_t [usertype] flags)
> v2 clear up two unnecessary variable, buf and blen.
> v3 fix patch format.
> v4 fix patch format again.
> 
> ---

not here

As is, the versioning information would end up
in the changlog and that isn't the desired style.

> diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
[]
> @@ -1835,19 +1835,14 @@ int iwctl_siwencodeext(struct net_device *dev,
[]
> +	param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL);

Also, param is a struct viawget_wpa_param * so
this should use:

	param = kzalloc(sizeof(*param), GFP_KERNEL);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/