linux-kernel - Re: [patch] ncpfs: cleanup indenting in ncp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140408142656.GI4963@mwanda>
Date:	Tue, 8 Apr 2014 17:26:56 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Petr Vandrovec <petr@...drovec.name>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dave Chiluk <chiluk@...onical.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] ncpfs: cleanup indenting in ncp_lookup()

Ping?

regards,
dan carpenter

On Mon, Feb 17, 2014 at 11:11:28PM +0300, Dan Carpenter wrote:
> My static checker suggests adding curly braces here.  Probably that was
> the intent, but actually the code works the same either way.  I've just
> changed the indenting and left the code as-is.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c
> index 91441de2529c..08b8ea8c353e 100644
> --- a/fs/ncpfs/dir.c
> +++ b/fs/ncpfs/dir.c
> @@ -849,8 +849,8 @@ static struct dentry *ncp_lookup(struct inode *dir, struct dentry *dentry, unsig
>  				 dentry->d_name.len, 1);
>  		if (!res)
>  			res = ncp_lookup_volume(server, __name, &(finfo.i));
> -			if (!res)
> -				ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
> +		if (!res)
> +			ncp_update_known_namespace(server, finfo.i.volNumber, NULL);
>  	} else {
>  		res = ncp_io2vol(server, __name, &len, dentry->d_name.name,
>  				 dentry->d_name.len, !ncp_preserve_case(dir));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/