linux-kernel - Re: [PATCH] clocksource: register cpu notifier to remove timer from dying CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKohpom7n=cbWJttvxgYCv7uzXQeJx4FzMZuyKWvNvbM6kmqjA@mail.gmail.com>
Date:	Tue, 8 Apr 2014 10:27:39 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>
Cc:	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Jet Chen <jet.chen@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linaro Networking <linaro-networking@...aro.org>,
	Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH] clocksource: register cpu notifier to remove timer from
 dying CPU

On 5 April 2014 17:33, Viresh Kumar <viresh.kumar@...aro.org> wrote:
>  kernel/time/clocksource.c | 64 +++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 53 insertions(+), 11 deletions(-)
>
> diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
> index ba3e502..8054fb1 100644
> --- a/kernel/time/clocksource.c
> +++ b/kernel/time/clocksource.c
> @@ -23,16 +23,21 @@
>   *   o Allow clocksource drivers to be unregistered
>   */
>
> +#include <linux/cpu.h>
>  #include <linux/device.h>
>  #include <linux/clocksource.h>
>  #include <linux/init.h>
>  #include <linux/module.h>
> +#include <linux/notifier.h>
>  #include <linux/sched.h> /* for spin_unlock_irq() using preempt_count() m68k */
>  #include <linux/tick.h>
>  #include <linux/kthread.h>
>
>  #include "tick-internal.h"
>
> +/* Tracks current CPU to queue watchdog timer on */
> +static int timer_cpu;
> +

Minor fixup, will send V2 after few days:

diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index 8054fb1..356c6c6 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -35,9 +35,6 @@

 #include "tick-internal.h"

-/* Tracks current CPU to queue watchdog timer on */
-static int timer_cpu;
-
 void timecounter_init(struct timecounter *tc,
                      const struct cyclecounter *cc,
                      u64 start_tstamp)
@@ -185,6 +182,9 @@ static char override_name[CS_NAME_LEN];
 static int finished_booting;

 #ifdef CONFIG_CLOCKSOURCE_WATCHDOG
+/* Tracks current CPU to queue watchdog timer on */
+static int timer_cpu;
+
 static void clocksource_watchdog_work(struct work_struct *work);
 static void clocksource_select(void);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/