lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 08 Apr 2014 17:04:26 -0700 From: Joe Perches <joe@...ches.com> To: Matei Oprea <eu@...eamatei.ro> Cc: jbottomley@...allels.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, ROSEdu Kernel Community <firefly@...ts.rosedu.org> Subject: Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory On Tue, 2014-04-08 at 23:42 +0300, Matei Oprea wrote: > It's easier to use kcalloc for allocating arrays. While at it > also remove useless casting value. [] > diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c [] > @@ -4742,12 +4742,14 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba) [] > - if (!phba->sli.ring) [] > + if (unlikely(!phba->sli.ring)) { Why add the unlikely? Glancing at the code it seems more like that this should be likely than unlikely. > + phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING, > + sizeof(struct lpfc_sli_ring), > + GFP_KERNEL); It'd be nicer looking if aligned better phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING, sizeof(struct lpfc_sli_ring), GFP_KERNEL); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists