linux-kernel - Re: [PATCH] ALSA: hda - Use runtime helper to check active state.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Apr 2014 09:36:08 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Dylan Reid <dgreid@...omium.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda - Use runtime helper to check active state.

At Tue,  8 Apr 2014 12:06:18 -0700,
Dylan Reid wrote:
> 
> >From azx_interrupt, use the helper to check if the device is active
> instead of checking the state.  This will do the right thing if
> runtime pm is disabled in addition to if the device is suspended.
> 
> Signed-off-by: Dylan Reid <dgreid@...omium.org>

Thanks, applied.


Takashi

> ---
>  sound/pci/hda/hda_controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
> index 97993e1..460fcf4 100644
> --- a/sound/pci/hda/hda_controller.c
> +++ b/sound/pci/hda/hda_controller.c
> @@ -1758,7 +1758,7 @@ irqreturn_t azx_interrupt(int irq, void *dev_id)
>  
>  #ifdef CONFIG_PM_RUNTIME
>  	if (chip->driver_caps & AZX_DCAPS_PM_RUNTIME)
> -		if (chip->card->dev->power.runtime_status != RPM_ACTIVE)
> +		if (!pm_runtime_active(chip->card->dev))
>  			return IRQ_NONE;
>  #endif
>  
> -- 
> 1.8.1.3.605.g02339dd
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/