linux-kernel - Re: [PATCH] staging: rtl8187se: fix pointer and return statement's syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140409092639.GA6733@leaf>
Date:	Wed, 9 Apr 2014 02:26:39 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Martin Kepplinger <martink@...teo.de>
Cc:	gregkh@...uxfoundation.org, teobaluta@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: fix pointer and return statement's
 syntax

On Wed, Apr 09, 2014 at 09:25:55AM +0200, Martin Kepplinger wrote:
> Use the common kernel coding style.
> 
> Signed-off-by: Martin Kepplinger <martink@...teo.de>

Reviewed-by: Josh Triplett <josh@...htriplett.org>
> 
>  drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> index 0dc5ae4..e6257b3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> @@ -180,7 +180,7 @@ static inline int ieee80211_put_snap(u8 *data, u16 h_proto)
>  int ieee80211_encrypt_fragment(struct ieee80211_device *ieee,
>  			       struct sk_buff *frag, int hdr_len)
>  {
> -	struct ieee80211_crypt_data* crypt = ieee->crypt[ieee->tx_keyidx];
> +	struct ieee80211_crypt_data *crypt = ieee->crypt[ieee->tx_keyidx];
>  	int res;
>  
>  	/*
> @@ -285,7 +285,7 @@ static int ieee80211_classify(struct sk_buff *skb,
>  
>  	if (!network->QoS_Enable) {
>  		skb->priority = 0;
> -		return(wme_UP);
> +		return wme_UP;
>  	}
>  
>  	if (eh->ether_type == __constant_htons(ETHERTYPE_IP)) {
> @@ -304,7 +304,7 @@ static int ieee80211_classify(struct sk_buff *skb,
>  	}
>  
>  	skb->priority = wme_UP;
> -	return(wme_UP);
> +	return wme_UP;
>  }
>  
>  /* SKBs are added to the ieee->tx_queue. */
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/