linux-kernel - Re: [PATCH] ASoC: core: Fix Sparse incompatible types warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53452F67.3060400@metafoo.de>
Date:	Wed, 09 Apr 2014 13:30:47 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: core: Fix Sparse incompatible types warning

On 04/09/2014 01:12 PM, Krzysztof Kozlowski wrote:
> On śro, 2014-04-09 at 12:57 +0200, Lars-Peter Clausen wrote:
>> On 04/09/2014 09:21 AM, Krzysztof Kozlowski wrote:
>>> Fix following Sparse warning:
>>> sound/soc/soc-core.c:252:20: error: incompatible types in comparison expression (different type sizes)
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>>> ---
>>>    sound/soc/soc-core.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
>>> index 051c006281f5..41f6178249df 100644
>>> --- a/sound/soc/soc-core.c
>>> +++ b/sound/soc/soc-core.c
>>> @@ -249,7 +249,7 @@ static ssize_t codec_reg_write_file(struct file *file,
>>>    	struct snd_soc_codec *codec = file->private_data;
>>>    	int ret;
>>>
>>> -	buf_size = min(count, (sizeof(buf)-1));
>>> +	buf_size = min(count, (size_t)(sizeof(buf)-1));
>>
>> But shouldn't the type of sizeof already be size_t?
>
> Hmmm... yes it should. It looks like a false positive from Sparse so the
> commit message should be rather "Suppress" than "Fix".

I'm pretty sure it is a bug in sparse, we shouldn't suppress those, but 
rather fix them in sparse itself.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/