linux-kernel - Re: [PATCH] staging: speakup: fix misuse of kstrtol() in handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHb8M2Dy3uKe9Vm05wR5VNFj7qYjw1Z_+Qic6O4HVHdzsu0amQ@mail.gmail.com>
Date:	Wed, 9 Apr 2014 22:53:52 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, sachin.kamat@...aro.org,
	devel@...verdev.osuosl.org, grygorii.strashko@...com,
	lisa@...apiadmin.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: fix misuse of kstrtol() in handle_goto()

2014-04-09 20:39 GMT+09:00, Dan Carpenter <dan.carpenter@...cle.com>:
> On Wed, Apr 09, 2014 at 07:45:46PM +0900, Daeseok Youn wrote:
>>
>> A string of goto_buf has a number followed by x or y.
>> e.g. "3x" means move 3 lines down.
>> The kstrtol() returns an error(-EINVAL) with this string so
>> go_pos has unsigned a value of that error.
>> And also "*cp" has not expected value.
>>
>
> Good catch.  This was introduced when we changed the simple_strtoul() to
> kstrtol().

Thanks! :-)

>
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> Did you find this bug by testing or through reading the code?
Actually, I couldn't test. I have looked the code for checking sparse
warnings and found this bug.

Regards,
Daeseok Youn

>
> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/