linux-kernel - Re: [PATCH RESEND] usb: ohci-exynos: Remove locks for 'ohci' in suspend callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <003a01cf5399$4e7e8590$eb7b90b0$%han@samsung.com>
Date:	Wed, 09 Apr 2014 11:13:32 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Vivek Gautam' <gautam.vivek@...sung.com>,
	'Alan Stern' <stern@...land.harvard.edu>
Cc:	linux-usb@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, kgene.kim@...sung.com,
	'Manjunath Goudar' <csmanjuvijay@...il.com>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH RESEND] usb: ohci-exynos: Remove locks for 'ohci' in
 suspend callback

On Tuesday, April 08, 2014 11:41 PM, Vivek Gautam wrote:
> 
> Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend
> has already removed 'ohci_hcd' settings from exynos glue layer
> as a part of streamlining the ohci controller's suspend.
> So we don't need the locks for 'ohci_hcd' anymore.

Right, this spin_lock/unlock is unnecessary, because it is
already used in ohci_suspend().

Acked-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> 
> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> Cc: Manjunath Goudar <csmanjuvijay@...il.com>
> Cc: Alan Stern <stern@...land.harvard.edu>
> ---
>  drivers/usb/host/ohci-exynos.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
> index 68588d8..9cf80cb 100644
> --- a/drivers/usb/host/ohci-exynos.c
> +++ b/drivers/usb/host/ohci-exynos.c
> @@ -190,17 +190,13 @@ static int exynos_ohci_suspend(struct device *dev)
>  {
>  	struct usb_hcd *hcd = dev_get_drvdata(dev);
>  	struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd);
> -	struct ohci_hcd *ohci = hcd_to_ohci(hcd);
>  	struct platform_device *pdev = to_platform_device(dev);
>  	bool do_wakeup = device_may_wakeup(dev);
> -	unsigned long flags;
>  	int rc = ohci_suspend(hcd, do_wakeup);
> 
>  	if (rc)
>  		return rc;
> 
> -	spin_lock_irqsave(&ohci->lock, flags);
> -
>  	if (exynos_ohci->otg)
>  		exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self);
> 
> @@ -208,8 +204,6 @@ static int exynos_ohci_suspend(struct device *dev)
> 
>  	clk_disable_unprepare(exynos_ohci->clk);
> 
> -	spin_unlock_irqrestore(&ohci->lock, flags);
> -
>  	return 0;
>  }
> 
> --
> 1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/