linux-kernel - Re: [PATCH 1/2] watchdog: add Intel MID watchdog driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140409174854.GC23274@psi-dev26.jf.intel.com>
Date:	Wed, 9 Apr 2014 10:48:54 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	wim@...ana.be, tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org, gnomes@...rguk.ukuu.org.uk,
	Eric Ernst <eric.ernst@...el.com>
Subject: Re: [PATCH 1/2] watchdog: add Intel MID watchdog driver support

On Tue, Apr 08, 2014 at 04:56:36PM -0700, Randy Dunlap wrote:
> On 04/08/2014 01:59 PM, David Cohen wrote:
> > Add initial Intel MID watchdog driver support.
> > 
> > This driver is an initial implementation of generic Intel MID watchdog
> > driver. Currently it supports Intel Merrifield platform.
> > 
> > Signed-off-by: Eric Ernst <eric.ernst@...el.com>
> > Signed-off-by: David Cohen <david.a.cohen@...ux.intel.com>
> > ---
> >  drivers/watchdog/Kconfig         |  12 +++
> >  drivers/watchdog/Makefile        |   1 +
> >  drivers/watchdog/intel-mid_wdt.c | 209 +++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 222 insertions(+)
> >  create mode 100644 drivers/watchdog/intel-mid_wdt.c
> > 
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 79d25894343a..4da09b8b2f11 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -643,6 +643,18 @@ config INTEL_SCU_WATCHDOG
> >  
> >  	  To compile this driver as a module, choose M here.
> >  
> > +config INTEL_MID_WATCHDOG
> > +	bool "Intel MID SCU Watchdog Mobile Platforms"
> > +	depends on X86_INTEL_MID && WATCHDOG_CORE
> > +	---help---
> > +	  Watchdog timer driver built into the Intel SCU for Intel MID
> > +	  Platforms.
> > +
> > +	  This driver currently supports only the watchdog evolution
> > +	  implementation in SCU, available for Merrifield generation.
> > +
> > +	  To compile this driver as a module, choose M here.
> 
> Does choosing M work when INTEL_MID_WATCHDOG is a bool?
> and why is INTEL_MID_WATCHDOG a bool?

The error here is the left over line from the template I used. There
should be no mention about choosing M.
It's bool because the watchdog is started by default on fw. We need this
driver probed during boot to pet/kick/ping asap. IMHO It makes not much
sense to compile it as module.

Br, David

> 
> > +
> >  config ITCO_WDT
> >  	tristate "Intel TCO Timer/Watchdog"
> >  	depends on (X86 || IA64) && PCI
> 
> 
> -- 
> ~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/