linux-kernel - Re: [PATCH linux-next] ALSA: usb-audio: Suppress repetitive debug messages from retire_playback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr456pbh2.wl%tiwai@suse.de>
Date:	Wed, 09 Apr 2014 21:08:25 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Tim Gardner <tim.gardner@...onical.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>,
	Eldad Zack <eldad@...refinery.com>,
	Daniel Mack <zonque@...il.com>,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH linux-next] ALSA: usb-audio: Suppress repetitive debug messages from retire_playback_urb()

At Wed,  9 Apr 2014 11:30:44 -0600,
Tim Gardner wrote:
> 
> BugLink: http://bugs.launchpad.net/bugs/1305133
> 
> Malfunctioning or slow devices can cause a flood of dmesg SPAM.
> 
> I've ignored checkpatch.pl complaints about the use of printk_ratelimit() in favour
> of prior art in sound/usb/pcm.c.
> 
> WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
> +	if (printk_ratelimit() &&
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Eldad Zack <eldad@...refinery.com>
> Cc: Daniel Mack <zonque@...il.com>
> Cc: Clemens Ladisch <clemens@...isch.de>
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>

Applied, thanks.


Takashi

> ---
>  sound/usb/pcm.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 49de5c1..131336d 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -1501,7 +1501,8 @@ static void retire_playback_urb(struct snd_usb_substream *subs,
>  	 * The error should be lower than 2ms since the estimate relies
>  	 * on two reads of a counter updated every ms.
>  	 */
> -	if (abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2)
> +	if (printk_ratelimit() &&
> +	    abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2)
>  		dev_dbg(&subs->dev->dev,
>  			"delay: estimated %d, actual %d\n",
>  			est_delay, subs->last_delay);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/