| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87ha63t6gb.fsf@sejong.aot.lge.com> Date: Wed, 09 Apr 2014 14:31:00 +0900 From: Namhyung Kim <namhyung@...il.com> To: Don Zickus <dzickus@...hat.com> Cc: acme@...nel.org, peterz@...radead.org, LKML <linux-kernel@...r.kernel.org>, jolsa@...hat.com, jmario@...hat.com, fowles@...each.com, eranian@...gle.com, andi.kleen@...el.com Subject: Re: [PATCH 6/6] perf, sort: Allow unique sorting instead of combining hist_entries On Mon, 24 Mar 2014 15:34:36 -0400, Don Zickus wrote: > The cache contention tools needs to keep all the perf records unique in order > to properly parse all the data. Currently add_hist_entry() will combine > the duplicate record and add the weight/period to the existing record. > > This throws away the unique data the cache contention tool needs (mainly > the data source). Create a flag to force the records to stay unique. No. This is why I said you need to add 'mem' and 'snoop' sort keys into the c2c tool. This is not how sort works IMHO - if you need to make samples unique let the sort key(s) distinguish them somehow, or you can combine same samples (in terms of sort kes) and use the combined entry's stat.nr_events and stat.period or weight. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists