linux-kernel - Re: [PATCH 4/4] HID: microsoft: undefining ms_map_key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5345DF91.5050701@cevel.net>
Date:	Thu, 10 Apr 2014 02:02:25 +0200
From:	Tolga Cakir <tolga@...el.net>
To:	Benjamin Tissoires <benjamin.tissoires@...il.com>
CC:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Derya <derya.kiran@...oo.de>, Jiri Kosina <jkosina@...e.cz>,
	Reyad Attiyat <reyad.attiyat@...il.com>,
	linux-input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] HID: microsoft: undefining ms_map_key_clear after
 usage

Am 09.04.2014 22:42, schrieb Benjamin Tissoires:
> On Fri, Apr 4, 2014 at 1:07 PM, Tolga Cakir <tolga@...el.net> wrote:
>> This is inspired by various other hid drivers.
>>
>> Signed-off-by: Tolga Cakir <tolga@...el.net>
>> ---
>>   drivers/hid/hid-microsoft.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
>> index 5674c0c..5281d2d 100644
>> --- a/drivers/hid/hid-microsoft.c
>> +++ b/drivers/hid/hid-microsoft.c
>> @@ -211,6 +211,8 @@ static int ms_sidewinder_kb_quirk(struct hid_input *hi, struct hid_usage *usage,
>>          return 1;
>>   }
>>
>> +#undef ms_map_key_clear
>> +
> Not sure this is really needed. The macro is prefixed by ms_, so I
> will simply let it there.
>
> Cheers,
> Benjamin
Ouch, I've just rechecked hid-lenovo-tpkbd.c and it wasn't prefixed 
there and therefore
needed. My fault, I'm sorry.

Greetings,
Tolga Cakir
>>   static int ms_sidewinder_control(struct hid_device *hdev, __u8 setup)
>>   {
>>          struct ms_data *sc = hid_get_drvdata(hdev);
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/