linux-kernel - Re: [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140410063540.GA25198@1wt.eu>
Date:	Thu, 10 Apr 2014 08:35:40 +0200
From:	Willy Tarreau <w@....eu>
To:	Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Neil Greatorex <neil@...boyfat.co.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Matthew Minter <matthew_minter@...atex.com>,
	linux-kernel@...r.kernel.org, Jason Cooper <jason@...edaemon.net>
Subject: Re: [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size

Hi Jason,

On Wed, Apr 09, 2014 at 10:20:40AM -0600, Jason Gunthorpe wrote:
> On Wed, Apr 09, 2014 at 08:11:29AM +0200, Willy Tarreau wrote:
> 
> > OK I just got it by adding two printk() in pci-mvebu.c. Both functions
> > mvebu_pcie_handle_iobase_change() and mvebu_pcie_handle_membase_change()
> > do pass a size which is in fact a mask (size - 1) and not the real size.
> > So the mbus is fed with an incorrect size which is off by one :
> 
> Yes, that is right. I tested my patch here and didn't see any problem,
> but I realize now that the mbus code is bailing early due to this:
> 
> kernel: mvebu_mbus: cannot add window '4:e8', conflicts with another window
> 
> Which I've never got around to fixing.. (whole other story there)
> 
> Your patch looks fine, and it obviously needs to be sequenced before
> mine. (Thomas/Jason C: how do you want to do this?)
> 
> Reviewed-By: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

OK, thank you. I've updated the attached patch with your better description.

Cheers,
Willy


View attachment "0001-pci-mvebu-fix-off-by-one-in-the-computed-size-of-the.patch" of type "text/plain" (1795 bytes)