linux-kernel - Re: [PATCH 3/4] arm: add basic support for Mediatek MT6589 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ha6136dz.fsf@approximate.cambridge.arm.com>
Date:	Thu, 10 Apr 2014 10:01:28 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Rob Herring <robherring2@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>
Cc:	Mark Rutland <Mark.Rutland@....com>, Andrew Lunn <andrew@...n.ch>,
	"linux-doc\@vger.kernel.org" <linux-doc@...r.kernel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	"heiko.stuebner\@bq.com" <heiko.stuebner@...com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Florian Vaussard <florian.vaussard@...l.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	"devicetree\@vger.kernel.org" <devicetree@...r.kernel.org>,
	Jason Cooper <jason@...edaemon.net>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-arm-kernel\@lists.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	Silvio F <silvio.fricke@...il.com>,
	Kumar Gala <galak@...eaurora.org>,
	Olof Johansson <olof@...om.net>,
	Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH 3/4] arm: add basic support for Mediatek MT6589 boards

A couple of things on top of Rob's comments:

On Wed, Apr 09 2014 at 10:50:33 pm BST, Rob Herring <robherring2@...il.com> wrote:
> On Wed, Apr 9, 2014 at 2:45 PM, Matthias Brugger <matthias.bgg@...il.com> wrote:
>> This adds a generic devicetree board file and a dtsi for boards
>> based on the MT6589 SoCs from Mediatek.
>>
>> Apart from the generic parts (gic, clocks) the only component
>> currently supported are the timers.
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>

[...]

>> diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
>> new file mode 100644
>> index 0000000..c0139ca
>> --- /dev/null
>> +++ b/arch/arm/mach-mediatek/Kconfig
>> @@ -0,0 +1,14 @@
>> +config ARCH_MEDIATEK
>> +       bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
>> +       select ARCH_REQUIRE_GPIOLIB
>
> Then where is your GPIO driver?
>
>> +       select ARM_GIC
>> +       select CACHE_L2X0
>> +       select HAVE_ARM_TWD if LOCAL_TIMERS

Hell no! ;-) ARM_ARCH_TIMER is the way (please also add the missing
node).

>> +       select HAVE_SMP
>
> Not needed now (going into 3.15).
>
>> +       select LOCAL_TIMERS if SMP

No, A7 always have the arch timers.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/