linux-kernel - Re: [PATCH v3 2/8] DMA: Freescale: unify register access methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53466573.7050901@freescale.com>
Date:	Thu, 10 Apr 2014 17:33:39 +0800
From:	Hongbo Zhang <hongbo.zhang@...escale.com>
To:	David Laight <David.Laight@...LAB.COM>,
	"vkoul@...radead.org" <vkoul@...radead.org>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
CC:	"scottwood@...escale.com" <scottwood@...escale.com>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"leo.li@...escale.com" <leo.li@...escale.com>
Subject: Re: [PATCH v3 2/8] DMA: Freescale: unify register access methods


On 04/10/2014 04:46 PM, David Laight wrote:
> From: hongbo.zhang@...escale.com
>> Methods of accessing DMA contorller registers are inconsistent, some registers
>                                 ^^

Thanks.
sorry, that it a typo.
I would wait to see if there are other defects I have to correct, if yes 
I can send a new iteration including this update, if no I would like to 
know if the maintainer can do me the favor to correct it when merging 
this patch, if still no, I will send a new iteration for this then.

>> are accessed by DMA_IN/OUT directly, while others are accessed by functions
>> get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR register, it
>> is read by get_bcr but written by DMA_OUT.
>> This patch unifies the inconsistent methods, all registers are accessed by
>> get/set_* now.
> 	David
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/