linux-kernel - Re: [PATCH 1/2] ARM: SAMSUNG: remove gpio flags in dev-backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000701cf54a2$7c1379c0$743a6d40$%han@samsung.com>
Date:	Thu, 10 Apr 2014 18:51:45 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Alexandre Courbot' <gnurou@...il.com>,
	'Alexandre Courbot' <acourbot@...dia.com>
Cc:	'Thierry Reding' <thierry.reding@...il.com>,
	'Bryan Wu' <cooloney@...il.com>,
	'Ben Dooks' <ben-linux@...ff.org>,
	'Kukjin Kim' <kgene.kim@...sung.com>,
	linux-pwm@...r.kernel.org, linux-gpio@...r.kernel.org,
	'Linux Kernel Mailing List' <linux-kernel@...r.kernel.org>,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH 1/2] ARM: SAMSUNG: remove gpio flags in dev-backlight

On Thursday, April 10, 2014 1:17 PM, Alexandre Courbot wrote:
> 
> Ping, can I have the Samsung folks review and ,aybe even merge this
> patch? enable_gpio_flags is never used in any code, is replaced by
> gpiod, and we would like to remove it altogether from pwm_bl. Thanks!

OK, I see. It looks good.

As far as I know, 'enable_gpio_flags' has not been being used
for Samsung platform. So, there will be no side effect,
if 'enable_gpio_flags' is removed from 'arch/arm/plat-samsung'
directory.

Reviewed-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> 
> Alex.
> 
> On Thu, Feb 27, 2014 at 2:53 PM, Alexandre Courbot <acourbot@...dia.com> wrote:
> > The pwm-backlight driver is moving to use the gpiod interface,
> > which has its own mapping mechanism for platform data GPIOs.
> > These mappings carry GPIO properties like active low so they don't have
> > to be explicitly handled by GPIO consumers.
> >
> > Because of this change, the enable_gpio_flags member of
> > platform_pwm_backlight_data is going away. dev-backlight was passing
> > this member, but had no user making use of it, so it can safely be
> > removed. Further GPIOs used by pwm-backlight are expected to be
> > defined using the mechanisms provided by the gpiod API.
> >
> > Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> > ---
> >  arch/arm/plat-samsung/dev-backlight.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/dev-backlight.c b/arch/arm/plat-samsung/dev-backlight.c
> > index be4ad0b21c08..2157c5b539e6 100644
> > --- a/arch/arm/plat-samsung/dev-backlight.c
> > +++ b/arch/arm/plat-samsung/dev-backlight.c
> > @@ -124,8 +124,6 @@ void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info,
> >                 samsung_bl_data->pwm_period_ns = bl_data->pwm_period_ns;
> >         if (bl_data->enable_gpio >= 0)
> >                 samsung_bl_data->enable_gpio = bl_data->enable_gpio;
> > -       if (bl_data->enable_gpio_flags)
> > -               samsung_bl_data->enable_gpio_flags = bl_data->enable_gpio_flags;
> >         if (bl_data->init)
> >                 samsung_bl_data->init = bl_data->init;
> >         if (bl_data->notify)
> > --
> > 1.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/