linux-kernel - Re: [PATCH 1/2] tty serial: xr17c15x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140410114648.68bfbf61@alan.etchedpixels.co.uk>
Date:	Thu, 10 Apr 2014 11:46:48 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Michael Welling <mwelling@...e.org>
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	jslaby@...e.cz
Subject: Re: [PATCH 1/2] tty serial: xr17c15x driver

On Wed, 9 Apr 2014 23:10:35 -0500
Michael Welling <mwelling@...e.org> wrote:

> The 8250_core driver is supposed to support these devices but it has
> soft lockups on some hardware. This driver was ported from the vendors
> 2.6.37 driver and has been proven to work.
> 
> I do not expect it to be merged, I am looking for feedback and
> possible fixes.

The thing to do is going to be to compare the various methods in the
driver with the 8250.c driver.

It appeas to be based upon an ancient 8250.c so if you want to pick up
all the changes then you need to compare with 8250.c, and if you want to
fix 8250.c instead you need to do exactly the same job so that seems a
more productive way to go about it IMHO.

There are bits of the driver you've pasted like the loop over ports for
shared IRQs you can't fix however, because they assume there is one
driver for all the ports. Not sure it matters though given your devices
are all going to be PCI bus.

Other thing to do would be to instrument serial_in/out and run the two
drivers briefly and compare the sequence of accesses and settings used.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/